-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the web client a Mopidy extension #5
Comments
@jodal I'm running into an error with Mopidy 0.19 from the github develop branch when trying to add tracks to a playlist or retrieving the current tracklist: DEBUG 2014-06-24 12:17:53,779 [68156:Thread-10] mopidy.http.handlers I followed the instructions for running Mopidy from GitHub. Do I also need to do something with with the extensions? |
Should be fixed by mopidy/mopidy@dba6e9b. Thanks! |
Fixed, excellent! Now I could see what went wrong: Angular adds an $$hashkey property to the js objects that isn't recognized when (de)serialized and sent to mopidy. Added a very dirty hack to mopidy.js that does the trick (by skipping serialization of $$hashkey properties), but I'm going to find a different solution that doesn't require patching mopidy.js. |
Looking at the comment at http://stackoverflow.com/a/23656919/828646, I guess you can't easily do |
Looks like a neat solution. Let's give it a try. |
Just remember that the |
Can searches and lookups result in duplicate tracks? This is what we bind with ng-repeat, not tl_tracks. So far, everything works fine with the 'track by track.uri' solution. |
As far as I can remember, there's nothing in core stopping you from having duplicate tracks in searches/lookups, but I don't see a use case for it, so if there you see any duplicates anywhere than should probably be reported as a bug against that backend. |
Created a branch mopidy-0.19 and it should now be possible to install moped from here:
|
This works great! It is so nice to be able to have the Mopidy client list, Lux, the API explorer and Moped running side by side. This only becomes better and better with every client joining in :-) I sent a PR (#6) with some small fixes. Each commit is hopefully self-explanatory. Some other barely related notes:
|
Found a bug: Playlists can have duplicate tracks, so
|
Then I'll think of something else to prevent sending In the near future I will create a Durandal-vs-Angular branch for historic purposes and reorganize the rest, so there's only one Moped client left. |
Mopidy 0.19 was released yesterday. Would be great to have the mopidy-0.19 branch of Moped merged and get a release up on PyPI. |
Done. The Mopidy-Moped package can be found at: https://pypi.python.org/pypi/Mopidy-Moped/0.3.0. Can someone give it a try and see if it works? Can't test it on the Raspberry PI because there seems to be an issue with 0.19 and Tornado 3.1. |
It's working for me :-) |
There's some warnings during the installation which is caused by old entries in the I started updating diff --git a/MANIFEST.in b/MANIFEST.in
index 1560c49..9b130c8 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,3 +1,4 @@
+include CHANGELOG.md
include LICENSE
include MANIFEST.in
include README.rst
@@ -5,10 +6,8 @@ include README.rst
recursive-include mopidy_moped ext.conf
recursive-include mopidy_moped/static *
-exclude README.md
-
-recursive-exclude angular *
recursive-exclude dist *
-recursive-exclude durandal *
-recursive-exclude html *
+recursive-exclude karma *
recursive-exclude screenshots *
+recursive-exclude src *
+recursive-exclude vendor * |
The manifest wasn't updated unfortunately after the source reorganization. As far as I can see everything is either included or excluded now. A new version 0.3.1 is on PyPI. |
The shortly upcoming Mopidy 0.19 release lets web clients be installed as Mopidy extensions. This makes it possible to install a web client simply by running e.g.
pip install Mopidy-Lux
and restarting Mopidy. No configuration changes needed. Nogit clone
or download-and-unzip.Multiple web clients can be installed at the same time, as each client is hosted with a prefix, e.g. Mopidy-Lux on
http://localhost:6680/lux/
. Mopidy provides a list of all installed web clients onhttp://localhost:6680/mopidy/
.Mopidy 0.19 hasn't been released yet, but this feature is complete and available in our develop branch. We want web client authors to start working on making all the web clients pip-installable.
The main sources of information is:
We'll be happy to help you get this working nicely. Let us know if you run into problems.
The text was updated successfully, but these errors were encountered: