Skip to content

Commit

Permalink
Minimal repro case for electron/packager#774
Browse files Browse the repository at this point in the history
  • Loading branch information
Martijn The committed Dec 12, 2017
1 parent 71199c4 commit 7d612fc
Show file tree
Hide file tree
Showing 6 changed files with 1,357 additions and 19 deletions.
28 changes: 9 additions & 19 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
{
"name": "electron-quick-start",
"name": "electron-quick-start-mono-repo",
"version": "1.0.0",
"description": "A minimal Electron application",
"main": "main.js",
"scripts": {
"start": "electron ."
},
"repository": "https://github.com/electron/electron-quick-start",
"keywords": [
"Electron",
"quick",
"start",
"tutorial",
"demo"
],
"author": "GitHub",
"license": "CC0-1.0",
"devDependencies": {
"electron": "~1.7.8"
}
"main": "index.js",
"repository": "git@github.com:martijnthe/electron-quick-start.git",
"author": "Martijn The <martijn.the@intel.com>",
"license": "MIT",
"private": true,
"workspaces": [
"packages/*"
]
}
File renamed without changes.
3 changes: 3 additions & 0 deletions main.js → packages/electron-app/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ const BrowserWindow = electron.BrowserWindow
const path = require('path')
const url = require('url')

// Will throw because is-number is not packaged!
const isNumber = require('is-number')

// Keep a global reference of the window object, if you don't, the window will
// be closed automatically when the JavaScript object is garbage collected.
let mainWindow
Expand Down
27 changes: 27 additions & 0 deletions packages/electron-app/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"name": "electron-quick-start",
"version": "1.0.0",
"description": "A minimal Electron application",
"main": "main.js",
"scripts": {
"start": "electron .",
"package": "electron-packager ."
},
"repository": "https://github.com/electron/electron-quick-start",
"keywords": [
"Electron",
"quick",
"start",
"tutorial",
"demo"
],
"author": "GitHub",
"license": "CC0-1.0",
"devDependencies": {
"electron": "~1.7.8",
"electron-packager": "^10.1.0"
},
"dependencies": {
"is-number": "^4.0.0"
}
}
File renamed without changes.

0 comments on commit 7d612fc

Please sign in to comment.