Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos found by codespell #351

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Typos found by codespell #351

merged 1 commit into from
Nov 2, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

Most of the typos occur in code comments, but two of them occur in user-visible strings.

@PartialVolume PartialVolume merged commit 9f58de6 into martijnvanbrummelen:master Nov 2, 2021
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch November 2, 2021 09:31
@PartialVolume
Copy link
Collaborator

Thanks for this, I'd not come across codespell before, if you fancy adding this as a workflow in nwipe, please feel free to do a PR.

@DimitriPapadopoulos
Copy link
Contributor Author

As a first step, I can modify setup.cfg so that developers can run codespell themselves.

As a second step, I can set up codespell so that it's run from within the CI, if the first step feels OK.

How does this sound?

@PartialVolume
Copy link
Collaborator

Sounds good. Thanks.

@DimitriPapadopoulos
Copy link
Contributor Author

See #353 for step 1.
See #355 for step 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DimitriPapadopoulos @PartialVolume