Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON prettifier breaks HTML encoded entities for non-JSON #3

Open
alex-sherwin opened this issue Jan 23, 2019 · 0 comments · May be fixed by #4
Open

JSON prettifier breaks HTML encoded entities for non-JSON #3

alex-sherwin opened this issue Jan 23, 2019 · 0 comments · May be fixed by #4

Comments

@alex-sherwin
Copy link

The way the current JSON prettifier logic works, it reads the contents as text, checks if it's JSON, if it is it prettifies it, then it always sets the data back.

It shouldn't be resetting the data it if didn't modify it (i.e. if it's not JSON), because this process will lose HTML entity encoding (most apparent when rendering XML responses, as it won't work at all as-is, since the < and > characters lose their encoding)

alex-sherwin added a commit to alex-sherwin/newman-reporter-htmlfull that referenced this issue Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant