Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for new matplotlib #22

Closed
wants to merge 0 commits into from
Closed

Conversation

MarvinT
Copy link

@MarvinT MarvinT commented Mar 18, 2018

addresses issue #19
compatible with any matplotlib 2.0+

@diimdeep
Copy link

Looks good!

@onesuper
Copy link

Hope this PR can be merged

@rubik
Copy link

rubik commented Oct 9, 2018

@martijnvermaat Can you merge this one and release please? The package is otherwise unusable.

@martijnvermaat
Copy link
Owner

Thanks for the contribution. The tests are failing (looks like because of some other matplotlib change) which makes it hard for me to merge. I'm more than happy to merge if the tests are fixed.

I don't use the package myself at the moment and don't really have time to look into it. If someone feels like maintaining it, feel free to fork.

@MarvinT
Copy link
Author

MarvinT commented Oct 9, 2018

Hey @martijnvermaat,

I could help maintaining it. Can you add me on pypi? https://pypi.org/user/marvint/

I'll try to look at the unit tests.

@MarvinT
Copy link
Author

MarvinT commented Oct 9, 2018

It seems the baseline pngs vary from system to system... I've tried generating them on several different machines and haven't been able to find a set that matches the travis-ci versions. Are you ok with me removing the comparison and just testing to see if the function calls complete without error?

@MarvinT
Copy link
Author

MarvinT commented Oct 10, 2018

I removed the mpl test comparison to the generated plots because they were different on every machine I built on and I never got a version that matched travis-ci. It might be possible to generate them using debug mode in travis if you really want to.

Also fixed a bunch of other small issues to get docs to build. It looks like it might be a good time to update the version number and possibly add me as a collaborator/maintainer 😉

@ErikBjare
Copy link

@martijnvermaat Please merge this and push it to pypi ❤️

@rubik
Copy link

rubik commented Oct 30, 2018

@martijnvermaat Can you merge this and publish a new version?

@MarvinT
Copy link
Author

MarvinT commented Nov 22, 2018

Hey all, I'm going to be taking over maintenance of calmap over on my repo: https://github.com/MarvinT/calmap/ . I'll try to push version 0.0.7 to pypi today with these fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants