Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

Compile to OS X #4

Open
mathieutozer opened this issue Feb 14, 2015 · 24 comments
Open

Compile to OS X #4

mathieutozer opened this issue Feb 14, 2015 · 24 comments

Comments

@mathieutozer
Copy link

After a very quick glance at the code, it seems as though this could be made to target OS X. What do you think?

@martijnwalraven
Copy link
Owner

I haven't tested it myself, but I don't see any principled reason why it couldn't work on OS X. Out of the top of my head the only real dependency right now is the application lifecycle and network reachability code. It shouldn't be too difficult to factor that out. I've actually stopped using CocoaPods in my own code and will add a project with a framework target soon. That should make it easier to support a separate OS X target.

@mathieutozer
Copy link
Author

I took a closer look and yes I think with some compile time flags it could
be easy to do.
On 2015年2月13日(金) at 18:53 Martijn Walraven notifications@github.com wrote:

I haven't tested it myself, but I don't see any principled reason why it
couldn't work on OS X. Out of the top of my head the only real dependency
right now is the application lifecycle and network reachability code. It
shouldn't be too difficult to factor that out. I've actually stopped using
CocoaPods in my own code and will add a project with a framework target
soon. That should make it easier to support a separate OS X target.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@gazzer82
Copy link

Do you think this is likely to happen? I am about to start a project that will have an iOS and OS X application and would very much like to use this framework in them both?

Thanks

Gareth

@martijnwalraven
Copy link
Owner

You'd have to spend some time removing iOS dependencies from the code and configuring the CocoaPods spec for both platforms (or set up separate framework targets), but I don't foresee any real trouble. I'm not sure when I'll get to this myself, as I'm not working on OS X apps right now, but it is on my to do list.

@mathieutozer
Copy link
Author

I took a look at it myself and found that the SimpleKeychain dependency to be the non trivial part. Everything else was pretty simple. Martjin what role does the keychain play? Could it be sidestepped for now so that we could move forward?

@mathieutozer
Copy link
Author

I've got it to compile by compiling out iOS specific pieces, and without having to comment out too much code ;)

I'm going to take it for a spin in one of my projects and if all goes well I'll put up a pull request.

@martijnwalraven
Copy link
Owner

Let me know how it goes. I'm in the process of making a few other changes to the project structure, so maybe you should wait for them to land before working on a pull request. We would also have to add separate targets for iOS and OS X, and change the Podspec.

@mathieutozer
Copy link
Author

Yep, I've already updated the podspec. The changes were minimal (they took
maybe 10 minutes to compile out with compile time flags) so go ahead.

On Tue, Apr 21, 2015 at 9:02 AM Martijn Walraven notifications@github.com
wrote:

Let me know how it goes. I'm in the process of making a few other changes
to the project structure, so maybe you should wait for them to land before
working on a pull request. We would also have to add separate targets for
iOS and OS X, and change the Podspec.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@Dev1an
Copy link

Dev1an commented Apr 24, 2015

Mathieu, can you publish an example OS X project that uses this meteor framework?

@mathieutozer
Copy link
Author

I had to update a sub dependency to support the OS X version of meteor-ios, so I guess I have to have that pulled first and then make another for meteor-ios.

Embarrassingly this is my first github pull request

@mathieutozer
Copy link
Author

First pull request for SimpleKeychain in case anyone wants to take a look

mathieutozer/SimpleKeychain@2b6d260?diff=split

@mathieutozer
Copy link
Author

Working version of Leaderboard for OS X
screen shot 2015-04-28 at 4 59 11 pm

@Dev1an
Copy link

Dev1an commented May 6, 2015

Can you put the source code of your OSX leaderbord example online?

@mathieutozer
Copy link
Author

I was waiting for the pull request for simple keychain to get done, do you
have a local working version of meteor for os x running and want to see how
to make a mac os x leaderboard app or can you wait until the official pull
request is ready?

On Wed, May 6, 2015 at 3:12 PM Devian notifications@github.com wrote:

Can you put the source code of your OSX leaderbord example online?


Reply to this email directly or view it on GitHub
#4 (comment)
.

@mathieutozer
Copy link
Author

Ok I've pushed a shaky version to https://github.com/mathieutozer/meteor-ios

I am still waiting for a pull request for SimpleKeychain to happen before making an official PR for meteor-ios, I can't work out how to reference my fork with the podspecs (and some googling tells me it is not possible anyway) so I just copied the keychain source into the meteor pod for now to share how this looks.

Also for some reason with this change the test target in the generated workspace is screwed up. If anyone can clone take a look that would be appreciated!

@ssteinerx
Copy link

Any more progress on this? I can help; I have a big paying project that could use this.

@mathieutozer
Copy link
Author

Hey I haven't worked on this for a while, I ran into a pretty nasty rebase. If you want to pick it up while I'm on vacation, go ahead!

@ssteinerx
Copy link

What's the nasty rebase, where are you at, and what can I do to help move it along?

@mathieutozer
Copy link
Author

Just rebasing my fork onto the latest master was pretty bad - maybe start
there?

On Mon, Aug 3, 2015 at 7:01 PM Steve Steiner notifications@github.com
wrote:

What's the nasty rebase, where are you at, and what can I do to help move
it along?


Reply to this email directly or view it on GitHub
#4 (comment)
.

@freysie
Copy link
Contributor

freysie commented Nov 12, 2015

+1

@mathieutozer
Copy link
Author

For people following along the master in this fork should work. Someone try it out?

https://github.com/mathieutozer/meteor-ios

@freysie
Copy link
Contributor

freysie commented Nov 14, 2015

Cool, @mathieutozer. I’ll check it out asap!

Does it include your OS X leaderboard sample?

@mathieutozer
Copy link
Author

Yes it does!

On Fri, Nov 13, 2015 at 7:39 PM Jakob Alminde notifications@github.com
wrote:

Cool, @mathieutozer https://github.com/mathieutozer. I’ll check it out
asap!

Does it include your OS X leaderboard sample?


Reply to this email directly or view it on GitHub
#4 (comment)
.

@freysie
Copy link
Contributor

freysie commented Nov 17, 2015

DUDE, SWEET!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants