Make formatter compatible with 5.1 code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request accepted. There is still grammar for hex numbers (which was introduced in 5.2). But I don't see how it may cause practical problems. (Special thanks for removing new operators (which I forgot to mention in #13) and for changing comments correspondingly.) |
|
According to https://www.lua.org/manual/5.1/manual.html part 2.1, hex numbers are already supported in 5.1, but maybe I overlooked something? |
|
Yes, you're right. I've quick-checked this wrong: instead of And also in 5.2 was added binary exponent part:
|
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Mar 3, 2022
For the last few years we have been using the wrong branch as the one we were on did not permit the use of `goto` as an identifier and "labels" as targets for such `goto`s as version of Lua after 5.1 forbode that as it became a command to uncontrollably jump around Lua scripts as it does in the C (or BASIC) programming languages! This change will pull in changes that @keneanung did to the lfc submodule as: * martin-eden/lua_code_formatter#15 * martin-eden/lua_code_formatter#16 but we had forgotten to use. This will close Mudlet#5997. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
to Mudlet/Mudlet
that referenced
this pull request
Mar 6, 2022
For the last few years we have been using the wrong branch as the one we were on did not permit the use of `goto` as an identifier and "labels" as targets for such `goto`s as version of Lua after 5.1 forbade that as it became a command to uncontrollably jump around Lua scripts as it does in the C (or BASIC) programming languages! This change will pull in changes that @keneanung did to the lfc submodule as: * martin-eden/lua_code_formatter#15 * martin-eden/lua_code_formatter#16 but we had forgotten to use. This will close #5997. Also add some of the `./github/` sub-directory files, to the qmake project file - so they show up in the QtCreator editor...! There are further changes needed to the QMake `OTHER_FILES`, `INSTALLS` and `DISTFILES` variables but they should be left to a further, separate PR. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14