Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calories import from Strava API #17

Closed
martin-ueding opened this issue Nov 21, 2023 · 4 comments
Closed

Fix calories import from Strava API #17

martin-ueding opened this issue Nov 21, 2023 · 4 comments
Labels
type: bug Something isn't working

Comments

@martin-ueding
Copy link
Owner

No description provided.

@martin-ueding martin-ueding added the type: bug Something isn't working label Nov 21, 2023
@martin-ueding
Copy link
Owner Author

It seems that the stravalib export always has None there. So I am not able to fix this here but would have to go to the library authors.

@martin-ueding
Copy link
Owner Author

There is already an upstream bug report for this: stravalib/stravalib#198

martin-ueding added a commit that referenced this issue Dec 3, 2023
@martin-ueding
Add code for explorer cluster history #17
122606d
@martin-ueding
Copy link
Owner Author

The issue is that the calories are only in the detailed activity data. Therefore one needs to do another request per activity. That is something that we can do!

martin-ueding added a commit that referenced this issue Feb 3, 2024
@martin-ueding
GH-17: Download calories from Strava
7c410e6
martin-ueding added a commit that referenced this issue Feb 3, 2024
@martin-ueding
GH-17: Refactor calory downloading a bit
7bb584b
martin-ueding added a commit that referenced this issue Feb 3, 2024
@martin-ueding
GH-17: Add total for progress bar
82e9170
martin-ueding added a commit that referenced this issue Feb 3, 2024
@martin-ueding
GH-17: Remember download position
1a18b5e
martin-ueding added a commit that referenced this issue Feb 3, 2024
@martin-ueding
GH-17: Load calories from Strava checkout, fix km there
038e49d
@martin-ueding
Copy link
Owner Author

Done in 0.19.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martin-ueding