Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep identity of activities regardless of file system location #92

Closed
martin-ueding opened this issue Feb 20, 2024 · 2 comments
Closed
Labels
type: bug Something isn't working
Milestone

Comments

@martin-ueding
Copy link
Owner

I've recently switched to activity files and noticed that they are considered a new activity when it is renamed or moved. This means that one has duplicate activities. This is not very nice.

Therefore it would be good if the identity of an activity was based on the hash of the activity file itself. When it is renamed, the metadata could be updated. When it is moved, the metadata like kind or equipment can be updated. In both cases it can be found via the hash of the file which doesn't change.

Deleting activities isn't possible due to the incremental nature of the explorer tiles. Removing an activity would make it hard to erase the visited tiles and almost impossible to do the correction to the tile history. In those cases we would have to delete the tile history and tile visits and create them again.

@martin-ueding
Copy link
Owner Author

I now use the Blake-2b hash of the activity file contents to form the identity of the activity. If one renames it, it will be picked up as the same activity and just update the metadata.

Will come in version 0.20.0

@martin-ueding martin-ueding added this to the 0.20.0 milestone Mar 2, 2024
@martin-ueding
Copy link
Owner Author

Version 0.20.0 is released you can update and try it out. If the issue persists, please reopen this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant