Extract speed unit from fit files #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the fit file uses m/s as speed unit, the values are converted to km/h
|
Thank's for the PR, I'm not sure when I can review it, but I hope I will get to it soon. |
martin-ueding
added a commit
that referenced
this pull request
Jan 13, 2024
|
I didn't know that the FIT file fields had units attached to them. That is a great thing, we can indeed just get the conversion from there. I've implemented it a little bit differently in order to make it a hard error when there is no unit or an unknown unit. So I haven't merged your code, but your idea is now part of the |
|
Definitely a cleaner solution compared to my quick fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the fit file uses m/s as speed unit, the values are converted to km/h.
I'm sure there is a cleaner way to do this, but this should work (or at least worked for the FIT-files I tested it with).