Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zhTW/zhCN #9

Merged
merged 7 commits into from
May 30, 2024
Merged

Update zhTW/zhCN #9

merged 7 commits into from
May 30, 2024

Conversation

EKE00372
Copy link
Contributor

#6

@EKE00372 EKE00372 changed the title Update zhTW Update zhTW/zhCN May 18, 2024
martinbjeldbak
martinbjeldbak approved these changes May 19, 2024
View reviewed changes
Copy link
Owner

@martinbjeldbak martinbjeldbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @EKE00372 !

martinbjeldbak
martinbjeldbak approved these changes May 19, 2024
View reviewed changes
Copy link
Owner

@martinbjeldbak martinbjeldbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just notice small need to add the two variables for %s in the saveLocationHelpText string

localization.zhCN.lua Outdated Show resolved Hide resolved
martinbjeldbak
martinbjeldbak approved these changes May 30, 2024
View reviewed changes
Copy link
Owner

@martinbjeldbak martinbjeldbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you again for contributing!

@martinbjeldbak martinbjeldbak merged commit 8a7f4e2 into martinbjeldbak:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbjeldbak martinbjeldbak martinbjeldbak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EKE00372 @martinbjeldbak