#88 streaming parse with generator - handling thread termination #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way I could implement generator is by using `threading` module. I
tried to play with `generator.send`, but without luck. I could not find any
other solution, how to give control outside of callback.
With this implementation using `threading` module I see the only issue with
incomplete parsing. For example:
data = '<a x="y"><b>1</b><b>2</b><b>3</b></a>'
next(parse(data, item_depth=2))
Here, we take only single item and a thread is left waiting for queue forever.
Since threads are daemonic, they will not block process termination, but in
cases, where many daemonic threads will be left running, then it will leak
memory.
…roducer thread after a timeout. Add another test case - close the generator by a break in the for loop.
…thon 2.x compatibility).
This means that the result from parse() in the streaming configuration has to be used from within the 'with' keyword.
…streaming-parse-with-generator
|
This branch has conflicts that must be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.