Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: skip k=1 in K-Means implementations #18

Merged
merged 2 commits into from
May 8, 2021
Merged

ENH: skip k=1 in K-Means implementations #18

merged 2 commits into from
May 8, 2021

Conversation

martinfleis
Copy link
Owner

@martinfleis martinfleis commented May 8, 2021

Closes #17

To-do:

  • test cuML

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #18 (2881920) into main (5cb041b) will decrease coverage by 0.71%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   62.85%   62.13%   -0.72%     
==========================================
  Files           3        3              
  Lines         603      618      +15     
==========================================
+ Hits          379      384       +5     
- Misses        224      234      +10     
Impacted Files Coverage Δ
clustergram/clustergram.py 78.67% <33.33%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb041b...2881920. Read the comment docs.

@martinfleis martinfleis merged commit 8c527d0 into main May 8, 2021
@martinfleis martinfleis deleted the skip_k1 branch May 8, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip k=1 for K-Means
2 participants