API: follow sklearn api conventions #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
fit()
fit()
has a sklearn-compatible signaturefit()
fit()
clears the dataGenerally following https://scikit-learn.org/stable/developers/develop.html when it makes sense to follow it.
Given the nature of Clustergram being typically composed of a series of estimators differing in a number of clusters, it is not possible to create an API like this that is compatible with existing sklearn plotting classes. I suppose that our existing alternative constructors are sufficient in this case.