Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add targets for .net standard 2.0 and/or 2.1 #101

Closed
bantza opened this issue Jul 13, 2023 · 1 comment
Closed

Please add targets for .net standard 2.0 and/or 2.1 #101

bantza opened this issue Jul 13, 2023 · 1 comment

Comments

@bantza
Copy link

bantza commented Jul 13, 2023

Could you add targets for .net standard 2.0 and/or 2.1 for the next release?

I had a .net standard 2.1 library using this package and on the solution using that library I got a lot of NU1605 detected package downgrade errors when publishing, because Holiday package was including old version of NETstandard.library to the build.

I have built the holiday package my self from the source in this repo targeting .net standard 2.1 (and only that, didn't want to install extra SDKs for other targets) and my solution publishes fine with it.

martinjw added a commit that referenced this issue Jul 15, 2023
@martinjw
Copy link
Owner

See the pre-release here https://github.com/martinjw/Holiday/releases/tag/2.29.1.0

@martinjw martinjw closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants