Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IPublicHolidays to separate nuget package #50

Closed
konradbartecki opened this issue Mar 4, 2021 · 2 comments
Closed

Move IPublicHolidays to separate nuget package #50

konradbartecki opened this issue Mar 4, 2021 · 2 comments

Comments

@konradbartecki
Copy link
Contributor

Hey, I have a minor issue, where I am building a feature in another public NuGet package that would optionally take IPublicHolidays as parameter.

Right now I would have to reference the whole Holiday package, but I actually only need to reference IPublicHolidays interface.

Would it be possible to move IPublicHolidays to a separate NuGet like Holiday.Interfaces or Holiday.Model?

I assume the main NuGet package Holiday would later depend on this newly created NuGet package.

@martinjw
Copy link
Owner

martinjw commented Mar 7, 2021

It seems odd to have a nuget package/dll with just one interface, when the entire holiday package/dll isn't that big to start with... It may give the impression the library is more complicated than it is?

@konradbartecki
Copy link
Contributor Author

If you say so I'll agree with you 😄 sounds fair enough. Thanks, I'll close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants