Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for specifying FDR threshold in plot_group_stats #75

Merged
merged 2 commits into from Nov 24, 2023

Conversation

KangchengHou
Copy link
Collaborator

No description provided.

@martinjzhang
Copy link
Owner

@KangchengHou this pull request didn't pass the test. Can you take a look? Thank you!

@KangchengHou
Copy link
Collaborator Author

@martinjzhang that is because toy adata only has n_obs = 30, while sc.pp.neighbors was called n_pcs = 40 - probably scanpy recently update their function to check this.

but now this is fixed - see the second commit

@martinjzhang
Copy link
Owner

Great! This is super fast (as always). Thank you!

@martinjzhang martinjzhang merged commit 1d325e4 into master Nov 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants