Skip to content

Commit

Permalink
chore: remove support for node 8-12, add 18 (open-telemetry#1065)
Browse files Browse the repository at this point in the history
* chore: remove node 8 and 10 from CI

* chore: update engines

* chore: add node 18 to CI

* fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket

* test: reference the actual error message

* test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality

In the CI there will be 3 instances of the API installed(relative to the repo root):

- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`,
- `./node_modules/@opentelemetry/api`,
- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.

* chore: remove support for node@12 updating the engines

* chore: remove test runs on node@12

* test(resource-detector-alibaba-cloud): revert change, disable tests for node@18

* fix: turn fastify tests off for node@18
  • Loading branch information
rauno56 committed Sep 15, 2022
1 parent fab4ba2 commit 22b806f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"author": "OpenTelemetry Authors",
"license": "Apache-2.0",
"engines": {
"node": ">=8.12.0"
"node": ">=14"
},
"files": [
"build/esm/**/*.js",
Expand Down

0 comments on commit 22b806f

Please sign in to comment.