[Fix] New line between breaking changes and issues

[xeptore]

Hey @martinmcwhorter!

This pull request is based on #13 with upgraded dependencies.

Fixes #12.

[codecov]

Codecov Report

Merging #14 (b4c8540) into main (6b3b3c1) will increase coverage by 9.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   79.47%   89.37%   +9.90%     
==========================================
  Files          12       12              
  Lines         380      386       +6     
  Branches       88       87       -1     
==========================================
+ Hits          302      345      +43     
+ Misses         77       40      -37     
  Partials        1        1              

Flag	Coverage Δ
unittests	89.37% <100.00%> (+9.90%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/prompts/type-maker.ts	100.00% <ø> (ø)
src/prompts/footer-maker.ts	75.43% <100.00%> (+75.43%)	⬆️

[xeptore]

One of the main causes for issues like this is the use of word-wrap package, which causes some uncertainty when combined with new-lines in filter pipelines, as it seems it trims leading and following empty lines from its input.

A better idea, for future refactors, in my opinion, will be:

• Separating new-lines management (both insertions and deletions) into a separate module, which might run in the last phase to transform final commit message as whole (not in the middle of the process and for each answer)
• Adding a validator-like module to uniform the CommitLint configuration we receive from users to a logically correct configuration then mapping it into a new configuration object which is independent of CommitLint and passed to other parts of the application instead of the CommitLint rules configuration object
• Do not mutate user answers, e.g., commit body, after submission. Currently, if a user enters commit message body, and submits by pressing Enter key, they see a new leading empty line gets added to their input immediately. Having user input unchanged until the final processing step, which is kind of the same phase as in the first bullet point, will increase user experience.

[martinmcwhorter]

Overall it looks good to go. I added a question and note to the review.

The coverage has decreased with this PR, please add tests for the additional functions to at least bring the coverage to the same percentage.

[xeptore]

@martinmcwhorter I added more tests for footer-maker module.

[martinmcwhorter]

Why is this changed from git to npx?

[xeptore]

I had an error on my local machine regarding the cz not being a git command. I will revert if it is only my problem.

[martinmcwhorter]

Hmm.. not sure. Maybe cz is no longer a git plugin. Lemme look into it.

[xeptore]

I am receiving this error:

git: 'cz' is not a git command. See 'git --help'.

[xeptore]

Reverted back to using git (b4c8540).

[xeptore]

@martinmcwhorter also we need to merge #13 as it has dependency upgrades which caused the version bump to 1.2.0 which is itself was the cause of this merge request becoming 1.2.1.