-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review span in face of p1024, p1089, p1872 (Continued from #14) #30
Milestone
Comments
17 tasks
some small change was apparently missed: |
martinmoene
added a commit
that referenced
this issue
Nov 22, 2019
martinmoene
added a commit
that referenced
this issue
Dec 1, 2019
p1872 - span should have size_type, not index_type
martinmoene
added this to In progress
in Review span in face of p1024, p1089 and Tristan Brindle's span implementation
Dec 2, 2019
martinmoene
changed the title
Review span in face of p1024 and p1089 (Continued from #14)
Review span in face of p1024, p1089, p1872 (Continued from #14)
Dec 2, 2019
martinmoene
added a commit
that referenced
this issue
Dec 2, 2019
martinmoene
added a commit
that referenced
this issue
Dec 2, 2019
martinmoene
added a commit
that referenced
this issue
Dec 3, 2019
martinmoene
added a commit
that referenced
this issue
Dec 3, 2019
martinmoene
added a commit
that referenced
this issue
Dec 4, 2019
also remove && variants of get<>(spn)
martinmoene
moved this from In progress
to Done
in Review span in face of p1024, p1089 and Tristan Brindle's span implementation
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
References:
voted in, 2019-02 Kona ISO C++ Committee Trip Report
voted in, 2018 Rapperswil ISO C++ Committee Trip Report
voted in, 2019-11 Belfast ISO C++ Committee Trip Report
Plan:
as_writeable_bytes()
toas_writable_bytes()
(in r7, thanks to @nolange, see below)span_FEATURE_COMPARISON
to0
(p1085)span_CONFIG_SIZE_TYPE
tostd::size_t
(p1089)span_CONFIG_EXTENT_TYPE
tostd::size_t
(p1089)Extent
to be unsigned withdynamic_extent
numeric_limits<index_type>::max()
orstatic_cast<extent_t>(-1);
(p1089)defined(__cpp_deduction_guides)
etc.: moved to Consider using feature test macros: defined(__cpp_deduction_guides) etc. (continued from #30) #48The text was updated successfully, but these errors were encountered: