Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review span in face of p1024, p1089, p1872 (Continued from #14) #30

Closed
7 tasks done
martinmoene opened this issue Jan 11, 2019 · 1 comment
Closed
7 tasks done

Comments

@martinmoene
Copy link
Owner

martinmoene commented Jan 11, 2019

References:

Plan:

  • Rename as_writeable_bytes() to as_writable_bytes() (in r7, thanks to @nolange, see below)
  • Structured bindings support for fixed-size spans (only non-dynamically-sized spans) (p1024)
  • Change default of span_FEATURE_COMPARISON to 0 (p1085)
  • Change default of span_CONFIG_SIZE_TYPE to std::size_t (p1089)
  • Change default of span_CONFIG_EXTENT_TYPE to std::size_t (p1089)
  • Allow also for Extent to be unsigned with dynamic_extent numeric_limits<index_type>::max() or static_cast<extent_t>(-1); (p1089)
  • Rename index_type to size_type (p1872)

@nolange
Copy link

nolange commented Nov 7, 2019

some small change was apparently missed:
rename as_writeable_bytes -> as_writable_bytes

martinmoene added a commit that referenced this issue Dec 1, 2019
p1872 - span should have size_type, not index_type
@martinmoene martinmoene added this to the v0.7.0 milestone Dec 2, 2019
@martinmoene martinmoene changed the title Review span in face of p1024 and p1089 (Continued from #14) Review span in face of p1024, p1089, p1872 (Continued from #14) Dec 2, 2019
martinmoene added a commit that referenced this issue Dec 4, 2019
also remove && variants of get<>(spn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants