Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cmake/Conan packaging #37

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Improve Cmake/Conan packaging #37

merged 3 commits into from
Mar 18, 2019

Conversation

pleroux0
Copy link
Contributor

Some changes to improve CMake/Conan packages. Related to points 3 and 4 of #4.

  1. Currently, the CMake install installs the package as either a 32bit or 64bit package. This is a header-only library so this isn't necessary.
  2. It installs the CMake targets to cmake/span-lite/span-lite-*.cmake. The previous location is not searched when running find_package from CMake.
  3. Run CMake install instead of copying files. This allows Conan/CMake projects to use find_package(span-lite) just like pure CMake projects. Makes where the dependency is coming from transparent.

Let me know if you want any adjustments or require any changes.

This library is a header only library and the CMake package should not
depend on the 32/64bit of the original compiler.
Makes find_package(span-lite) work as expected from CMake projects that
use conan to handle dependencies.
@pleroux0
Copy link
Contributor Author

The failure from AppVeyor is from their side and is unrelated to my changes. The CI just needs to be started again.

@martinmoene martinmoene merged commit 4d9d174 into martinmoene:master Mar 18, 2019
@martinmoene
Copy link
Owner

Thanks @pleroux0 .
Looks good to me (inso(not very)far as I'm able to judge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants