Changing .to_string to .to_hex_string to fix conflict and added a Display impl for Record #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey, I just wanted to say thank you for contributing your fix! I'm really happy you've been able to put this to good use. I'd love to hear more about what you're building with it. |
|
Since this breaks API, I'll probably have to bump the major version. While I'm in there, I'll take a pass at cleanup/modernization, and see if I can't have a new crate version uploaded by EOD tomorrow. |
|
Great thank you. I am using this to strip a hex file, creating a binary app image which I can use for bootloading a IoT device. I really appreciate the work you have put in. It’s helped me a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some clean up using clippy recommendations.
I changed .to_string to .to_hex_string to prevent it conflicting with the .to_string method which I think is part of the std library.
I added a Display impl for Record which outputs the addresses in HEX to help with address debugging.