chore: mark ObjectKey::identifier function as deprecated

It will be removed entirely as part of the future minor or major
release.

src/macros.rs

@@ -389,14 +389,17 @@ macro_rules! block_label {
 /// ## Examples
 ///
 /// ```
-/// use hcl::ObjectKey;
+/// # fn main() -> Result<(), Box<dyn std::error::Error>> {
+/// use hcl::{Identifier, ObjectKey};
 ///
-/// assert_eq!(hcl::object_key!(some_identifier), ObjectKey::identifier("some_identifier"));
+/// assert_eq!(hcl::object_key!(some_identifier), ObjectKey::from(Identifier::new("some_identifier")?));
 /// assert_eq!(hcl::object_key!("some string"), ObjectKey::from("some string"));
 ///
 /// let key = "some expression";
 ///
 /// assert_eq!(hcl::object_key!((key)), ObjectKey::from("some expression"));
+/// #     Ok(())
+/// # }
 /// ```
 #[macro_export]
 macro_rules! object_key {
@@ -424,7 +427,8 @@ macro_rules! object_key {
 /// ## Examples
 ///
 /// ```
-/// use hcl::{Expression, Object, ObjectKey};
+/// # fn main() -> Result<(), Box<dyn std::error::Error>> {
+/// use hcl::{Expression, Identifier, Object, ObjectKey};
 ///
 /// let other = "hello";
 ///
@@ -435,12 +439,14 @@ macro_rules! object_key {
 /// });
 ///
 /// let expected = Expression::Object(Object::from([
-///     (ObjectKey::identifier("foo"), true.into()),
+///     (ObjectKey::from(Identifier::new("foo")?), true.into()),
 ///     (ObjectKey::from("baz qux"), vec![1u64, 2].into()),
 ///     (ObjectKey::from("hello"), "world".into()),
 /// ]));
 ///
 /// assert_eq!(expression, expected);
+/// #     Ok(())
+/// # }
 /// ```
 #[macro_export]
 macro_rules! expression {

src/ser/tests.rs

@@ -87,7 +87,10 @@ fn serialize_body() {
                 )
                 .add_attribute(("an_object", {
                     Object::from([
-                        (ObjectKey::identifier("foo"), Expression::from("bar")),
+                        (
+                            ObjectKey::from(Identifier::unchecked("foo")),
+                            Expression::from("bar"),
+                        ),
                         (
                             ObjectKey::from("enabled"),
                             Expression::from(RawExpression::new("var.enabled")),

src/structure/expression.rs

@@ -245,6 +245,7 @@ pub enum ObjectKey {
 
 impl ObjectKey {
     /// Creates an unquoted string identifier `ObjectKey`.
+    #[deprecated(since = "0.9.0", note = "use `ObjectKey::from(identifier)` instead")]
     pub fn identifier<I>(identifier: I) -> Self
     where
         I: Into<Identifier>,
@@ -262,6 +263,12 @@ where
     }
 }
 
+impl From<Identifier> for ObjectKey {
+    fn from(ident: Identifier) -> Self {
+        ObjectKey::Identifier(ident)
+    }
+}
+
 impl From<ObjectKey> for String {
     fn from(key: ObjectKey) -> Self {
         key.to_string()

src/tests.rs

@@ -42,7 +42,7 @@ fn expression_macro_objects() {
     );
 
     let expected = Expression::Object(Object::from([
-        (ObjectKey::identifier("foo"), "bar".into()),
+        (ObjectKey::from(Identifier::unchecked("foo")), "bar".into()),
         (ObjectKey::from("bar"), true.into()),
         (
             ObjectKey::Expression(RawExpression::from("qux").into()),