Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(structure): handle absence of trailing newline in body #273

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(structure): handle absence of trailing newline in body #273

merged 1 commit into from
Jul 14, 2023

Conversation

martinohmann
Copy link
Owner

@martinohmann martinohmann commented Jul 14, 2023 •
edited
Loading

Fixes #270
Closes #271

@martinohmann
Copy link
Owner Author

@denfren This is how I would fix #270, happy about feedback.

@martinohmann martinohmann force-pushed the issue-270 branch 3 times, most recently from e65b374 to 3266acc Compare July 14, 2023 21:43
@denfren
Copy link
Contributor

denfren commented Jul 14, 2023

Looking good! My only thought is that i would change prefer_trailing_newline => prefer_omit_trailing_newline because omitting is the special case that is being requested.

@denfren denfren mentioned this pull request Jul 14, 2023
Closed
@martinohmann
Copy link
Owner Author

Looking good! My only thought is that i would change prefer_trailing_newline => prefer_omit_trailing_newline because omitting is the special case that is being requested.

Yeah, that's better, I was about to copy that from your draft implementation. Will update the PR.

@martinohmann
Copy link
Owner Author

@denfren Updated

@martinohmann martinohmann merged commit 2f54cb1 into main Jul 14, 2023
5 checks passed
@martinohmann martinohmann deleted the issue-270 branch July 14, 2023 22:02
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denfren denfren denfren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hcl-edit: hardcoded newline for Body
2 participants
@martinohmann @denfren