feat(eval): add Evaluate::evaluate_in_place
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables partial expression evaluation where not all sub-expression cannot be resolved yet due to missing variables or function definitions.
This are false positives in this case. The `is_empty` method does not make any sense on `Errors` since it always contains at least one error. Replacing `fold` with `try_fold` in will short-circuit, which is not what we want.
martinohmann
force-pushed
the
hcl-rs/in-place-eval
branch
from
72aeabd
to
c03f1c6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184.
Key difference to the existing
Evaluate::evaluatemethod:This allows for partial expression evaluation, e.g. to support use cases where a HCL document contains variable references to other parts within the same document that themselves contain expressions that are not evaluated yet.
In this case one would:
evaluate_in_place.Contextwith newly discovered variables.