CancellationToken parameters must come last #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Will definitely get this merged, but I think I will complete 2.0 first since its in RC already, and include this in the 3.0 release. There are other changes in the pipeline as well so 3.0 should be pretty quick. I'll se about finishing 2.0 over the coming days |
|
hi there, any update on this? do you need a hand maybe? |
|
From my side - 2.0 and 2.1 has been released. Next step is 3.0 release which will include this change and a lot of others. There are some conflicts here now so they need to be resolved first, after that this can be included in a 3.0-preview pretty quickly. |
9 tasks
martinothamar
force-pushed
the
fix/ctk-param-should-be-last
branch
from
0257823
to
8449996
Compare
|
I just rebased and pushed some additional fixes due to the rebase. Thanks for the PR! (and sorry for the delay 😄) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also aligns with latest MediatR version as of change: jbogard/MediatR#772