Rollup of various changes on my side #26
Conversation
Generate a JAR that contains all intermediates for later reference.
This is to allow compiling with certain features enabled even on JC platforms that do not support those features. Among those features is using annotations.
Makes for better readability.
|
All in all they look like good cleanups, give me some time to go through them. Regarding File vs Path - there was something specific that made me decide to stick to Path-s, IIRC related to weird chars and Windows. |
| @@ -287,6 +289,10 @@ public void setExport(String msg) { | |||
| output_exp = msg; | |||
| } | |||
|
|
|||
| public void setJar(String msg) { | |||
|
Regarding File vs Path: I'll be investigating this and try to find out what your problem was. All in all Path is the more modern API. Too bad it conflicts with ant so badly. File seemed to yield simpler code, but maybe that was a mistake. |
|
Maybe it was a brainfart. I Usually leave a comment at the troublesome point, but as I do not see one, maybe it did not exist or got resolved. Thank you for the cleanup! |
|
Right. Try to run in a folder with space in the name. |
|
Yuk. Sounds like it will affect many users. I will try to figure this out tomorrow. Also forgot documenting another option so this needs another PR anyway. |
|
Actually couldn't leave this alone and took a look. The cause is not the use of File but how the files get passed as arguments to ant. Working on solution. |
|
FYI: After giving it some thought, I removed |
|
Hey @martinpaljak , tried to port some build stuff to Is there another way to force version? Because I get |
|
@gitfineon could you please clarify your scope and open a new issue ? |
This series of patches contains both some cleanups and some functional enhancements:
Would you be willing to accept these as-is or should I separate the functional changes from the rest?