Convert method arguments to dbus signatures #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whot
force-pushed
the
wip/check-dbus-signature
branch
from
0310d94
to
84e758b
Compare
No functional changes other than a reshuffling of types and renaming of args to make mypy happy.
We need to use the private attribute _dbus_in_signature from the method, it's the only way to get to the actual signature. Wrap it through getattr() so pylint doesn't complain. Fixes f8709a9 Fixes martinpitt#118
whot
force-pushed
the
wip/check-dbus-signature
branch
from
84e758b
to
61b7754
Compare
martinpitt
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Thank you! I confirmed that this also fixes ofono after reverting commit e52f87e. In hindsight, I should have been a bit more sceptical back then.. I'll land this, revert the hack, and do a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118