setup.py: Fix ModuleNotFoundError #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 842d250 broke `pip install` and also some variants of PEP-517 build tools: `.` is not in their default `sys.path` any more. Merely adding that to the search path is not sufficient: building an sdist in a venv is tripping over the missing `import dbus`, as dbus-python is just a runtime dependency, not a build-time one. So instead of importing `dbusmock.__version__` in setup.py, ask setuptools to dynamically generate the version in a declarative way, in setup.cfg. Many thanks to Michał Górny for analyzing this and proposing this solution! Fixes #142
|
I tested this with both |
mgorny
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
LGTM. BTW, you may consider switching fully to setup.cfg:
https://setuptools.pypa.io/en/latest/userguide/declarative_config.html
It's there since 2017, so I think it should be safe to use by now ;-). It can also replace reading README.md manually.
|
@mgorny: Ack, thanks! I'll look into that. I also want to add a test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 842d250 broke
pip installand also some variants ofPEP-517 build tools:
.is not in their defaultsys.pathany more.Merely adding that to the search path is not sufficient: building an
sdist in a venv is tripping over the missing
import dbus, asdbus-python is just a runtime dependency, not a build-time one.
So instead of importing
dbusmock.__version__in setup.py, asksetuptools to dynamically generate the version in a declarative way, in
setup.cfg.
Many thanks to Michał Górny for analyzing this and proposing this
solution!
Fixes #142