updated react support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated to react 16. * created a component mounting helper to initalize react componenets from rails views * create a component registery, so that plugins can register their top level containers * broke down generate webpack chunks into plugin specific vs common js code (to avoid duplications of js code within the bundle) * change webpack source maps to inline so it can easily be used to debug in the browser. (see webpack/webpack#2145) * updated webpack configuration so it can read from a package.json defined on a plugin
|
@martinpovolny in order to test this PR, you would need to use https://github.com/ohadlevy/miq_experimental_ui_plugin |
|
@martinpovolny would you prefer I'll open a new PR against core? thanks |
|
@ohadlevy : yes, please open a new PR against manageiq-ui-classic We are close to getting the release out of the door, let's restart the work on this. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from rails views
top level containers
js code (to avoid duplications of js code within the bundle)
debug in the browser. (see Source Maps don't work on Chrome webpack/webpack#2145)
defined on a plugin
TODO: add missing tests (I need jest support first in order to include them).