Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pulls All Content #103

Closed
nebutron opened this issue Mar 13, 2017 · 6 comments
Closed

Update Pulls All Content #103

nebutron opened this issue Mar 13, 2017 · 6 comments
Assignees
Labels
Component-DB Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Milestone

Comments

@nebutron
Copy link

Brief description of the issue.

Using RSS Guard on Antergos and when using the Update All Items button it does a few different things. Sometimes it will grab everything the feed has, 1000s of items (old and new). Sometimes it will grab my YouTube folder and feeds within it (all of them, not new ones) but grab new items of other feeds outside of the folder.

Sometimes it works normally where it only grabs new items but it seems random.

How to reproduce the bug?

  1. Open RSS Guard 3.4.0 on latest Antergos Cinnamon (not cloud accounts, local database)
  2. Click the green Update All Items Button
  3. Mark Everything As Read
  4. Minimise to Tray
  5. Click to Open, hit Update All Items Button Again
  6. Watch something different happen each time.

What is the expected result?

Clicking the Update All Items button should grab any new posts from these feeds and nothing that is old or already read.

What actually happened?

It grabs all posts from the different feeds, old and previously read items. Sometimes it does this to all feeds, sometimes to only feeds within a folder.

@martinrotter
Copy link
Owner

Give me here exact feed links which do that.

RSS Guard can mark some feed's messages as new again, if it gets new content for the message.

@nebutron
Copy link
Author

nebutron commented Mar 13, 2017

Well it seems to mostly be my YouTube RSS feeds so I will give two examples

https://www.youtube.com/feeds/videos.xml?channel_id=UCBJycsmduvYEL83R_U4JriQ

and

https://www.youtube.com/feeds/videos.xml?user=Jayztwocents

They are all doing it though. I suppose these videos are getting comments and causing the issue but my older RSS reader (RSSOwl) was not doing this.

I do now see this feed set to ATOM 1.0 instead of RSS 2.0, not sure if that matters?

@martinrotter
Copy link
Owner

OK, I will do some testing tomorrow. I see, the comments under each message COULD BE the real issue. RSS Guard checks if the message has new date/time. If it does, it overwrites the message in the database and sets it as unread. Perhaps, this does not make particular sense for YouTube feeds.

@martinrotter
Copy link
Owner

I am checking those feeds. It seems they contain up to 15 NEWEST entries (messages) even if the YouTube channel has more videos.

When any video gets new comment of anything changes, it is pushed into the feed and replaces some other older message in it, so that feed contains still max 15 messages. In RSS Guard, this will look like this:

  • you get 15 messages,
  • (now some video gets new comment or is updated or whatever)
  • you get new X messages (the X messages which were updated or commented on).

But the actual contents of those messages are UNCHANGED. Therefore I made the change to take contents changes into account too. Now, the message will re-appear only if contents is changed too.

@martinrotter martinrotter added this to the 3.4.1 milestone Mar 14, 2017
@martinrotter martinrotter added Component-DB Type-Enhancement This is request for brand new feature. labels Mar 14, 2017
@martinrotter martinrotter self-assigned this Mar 14, 2017
martinrotter added a commit that referenced this issue Mar 14, 2017
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Mar 14, 2017
@nebutron
Copy link
Author

nebutron commented Apr 7, 2017

Any idea when this will be pushed? Sorry to bug? Using the version from the AUR

@martinrotter
Copy link
Owner

You can always use https://aur.archlinux.org/packages/rssguard-git/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-DB Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Projects
None yet
Development

No branches or pull requests

2 participants