Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in News 15.1.0 #293

Closed
Grotax opened this issue Nov 11, 2020 · 1 comment
Closed

Breaking change in News 15.1.0 #293

Grotax opened this issue Nov 11, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@Grotax
Copy link

Grotax commented Nov 11, 2020

Brief description of the issue.

With news 15.1.0 we have a change in the feed attribute "folderId", if the feed is in the root folder the id will be "null" instead of 0.

See nextcloud/news#939

How to reproduce the bug?

  1. Install 15.1.0-rc2
  2. sync
  3. ...

What was the expected result?

Accept both 0 and null as a value at least for a while to allow for a smooth transition.

@martinrotter martinrotter self-assigned this Nov 11, 2020
@anoymouserver
Copy link

Probably not an issue since QJsonValue::toInt falls back to 0 if the value is not a number.

cats.value(QString::number(item["folderId"].toInt()))->appendChild(feed);

@martinrotter martinrotter added this to the 3.8.1 milestone Nov 12, 2020
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants