Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop running update doesn't seem working #52

Closed
blackarcher21 opened this issue Aug 19, 2016 · 2 comments
Closed

stop running update doesn't seem working #52

blackarcher21 opened this issue Aug 19, 2016 · 2 comments
Assignees
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@blackarcher21
Copy link

Brief description of the issue.

Stop running update doesn't seem working to me. Windows 8.1 x64, RSS Guard 3.3.3

How to reproduce the bug?

  1. Running update on certain feed/category
  2. Stop running update by click button on toolbar/status bar/via menu

What is the expected result?

Running update is stopped

What actually happened?

Update keep running until finished

@martinrotter
Copy link
Owner

Yes, I have observed this issue. Working on it.

@martinrotter martinrotter added this to the 3.3.4 milestone Aug 19, 2016
@martinrotter martinrotter self-assigned this Aug 19, 2016
@martinrotter
Copy link
Owner

Actually, the feature works. Problem is when you hit "update feeds". Each feed's update is immediately started in its own thread and all feeds download their new message simultaneously/in parallel. This action cannot be interrupted. When some feed finishes downloading of messages, then those messages are saved into DB, saving is NOT parallelized and is done synchronously in main thread. This action can be interrupted.

So the phase where feeds are all started and downloading cannot be interrupted. I will make some enhancements to make "stopping" faster IF POSSIBLE. But in general, stopping of feeds update will not work fast. This is by design and is caused by recent new feature - feed parallel updates.

martinrotter added a commit that referenced this issue Aug 25, 2016
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

2 participants