Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale file names #75

Closed
lgbaldoni opened this issue Dec 9, 2016 · 11 comments
Closed

Locale file names #75

lgbaldoni opened this issue Dec 9, 2016 · 11 comments
Assignees
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Desktop-Integration Application badly integrates into used desktop environment. Type-Enhancement This is request for brand new feature.
Milestone

Comments

@lgbaldoni
Copy link

Linux packaging would be a tad easier if locale files had an
underscore instead of a hyphen in their names.
E.g. rssguard-en.ts -> rssguard_en.ts, otherwise they might not
be recognised as l10n.

@martinrotter
Copy link
Owner

How exactly would be Linux packaging easier? Can you put some example here, please? :)

otherwise they might not be recognised as l10n.

Why?

@martinrotter martinrotter self-assigned this Dec 20, 2016
@martinrotter martinrotter added Component-Core Type-Desktop-Integration Application badly integrates into used desktop environment. Type-Enhancement This is request for brand new feature. labels Dec 20, 2016
@lgbaldoni
Copy link
Author

I don't know whether this is a general Qt guideline or not, but when building a separate -lang package, some distros like openSUSE, Fedora, Mageia et al. use the %find_lang macro which fails to identify the locale files when a hyphen instead of an underscore is used as separator (see https://github.com/rpm-software-management/rpm/blob/master/scripts/find-lang.sh#L116).

Regards

@martinrotter
Copy link
Owner

martinrotter commented Dec 20, 2016

So when you tried to use hyphens, it worked? Does replacing underscores with hyphens do the trick? If so, then I guess I could rename those files.

@lgbaldoni
Copy link
Author

The other way around, but yes. I apply this patch to package rssguard on openSUSE (the path is not relevant though).

@martinrotter
Copy link
Owner

Nice patch!

But why is directory l10n renamed to directory lang? Is that a change I should include in main rssguard repo too?

@martinrotter
Copy link
Owner

Follow-up: You package RSS Guard "officially" for some distro?

@lgbaldoni
Copy link
Author

Oh no, the path is not important, I just changed it because every other app I encountered used the "lang" folder.

Concerning the rest, I submitted rssguard to be included in the main repository, but these things take time.

By the way, I recently updated the Italian translation on transifex if you want to integrate it.

@martinrotter
Copy link
Owner

Oh no, the path is not important, I just changed it because every other app I encountered used the "lang" folder.

I see, I could change it too, "lang" is more self-descriptive.

By the way, I recently updated the Italian translation on transifex if you want to integrate it.

Perfect, I will trigger the sync and push it to repo.

@martinrotter martinrotter added this to the 3.4.0 milestone Dec 21, 2016
@martinrotter martinrotter added the Status-Accepted I will eventually implement this. label Dec 21, 2016
martinrotter added a commit that referenced this issue Feb 8, 2017
martinrotter added a commit that referenced this issue Feb 8, 2017
@martinrotter martinrotter added Status-Fixed Ticket is resolved. and removed Status-Accepted I will eventually implement this. labels Feb 8, 2017
@lgbaldoni
Copy link
Author

Sorry, I still see locale filenames using hyphens instead of underscores.

@martinrotter
Copy link
Owner

You need to check [dev] branch, https://github.com/martinrotter/rssguard/tree/dev

@lgbaldoni
Copy link
Author

Ouch, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Desktop-Integration Application badly integrates into used desktop environment. Type-Enhancement This is request for brand new feature.
Projects
None yet
Development

No branches or pull requests

2 participants