Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Failing loading images from RSS feed with authentication enabled #909

Closed
lrea opened this issue Mar 16, 2023 · 6 comments
Closed
Assignees
Labels
Component-Network Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@lrea
Copy link

lrea commented Mar 16, 2023

Brief description of the issue

The tool fail loading images from authenticated Jira and Confluence RSS feeds, I suppose it's because authentication is only used to retrieve content of articles, not to load images.

How to reproduce the bug?

add a feed which points to an RSS Feed with authentication enabled

What was the expected result?

loading images inside articles

What actually happened?

content of article is showed without images (they appear with a broken icon)

Debug log

no relevant info

Operating system and version

  • OS: Windows 10
  • RSS Guard version: 4.3.2
@lrea lrea added the Type-Defect This is BUG!!! label Mar 16, 2023
@martinrotter
Copy link
Owner

martinrotter commented Mar 16, 2023

Well, to actually fix this, I would need some example authenticated feed. Also, is this with classic or nonwebengine rssguard?

@martinrotter
Copy link
Owner

martinrotter commented Mar 16, 2023

EDIT: Just checked with some Jira/Confluence acc I have. Personal activity stream feed is really behind authentication and Jira does have "personal access token" feature. The token can be generated on the website and then is passed to each auth request via "Authentication" feature.

https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html#UsingPersonalAccessTokens-UsingPATs

This feature is indeed not yet supported because RSS Guard so far only supports HTTP Basic authentication for feeds while this is HTTP Bearer authentication (de facto OAuth).

@martinrotter
Copy link
Owner

started to work on this

image

@martinrotter
Copy link
Owner

checked with my Qt Bugreports acc and images work now, but this is now highly experimental feature

image

martinrotter added a commit that referenced this issue Mar 16, 2023
@lrea
Copy link
Author

lrea commented Mar 16, 2023

Is there any chance to have soon a minor release with the issue fixed ?

@martinrotter
Copy link
Owner

Yes, but you can always download development build.

@martinrotter martinrotter added this to the 4.3.3 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Network Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

2 participants