Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Multiple issues with Article Filter and Article Highlighter buttons #943

Closed
Rex000 opened this issue May 3, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@Rex000
Copy link

Rex000 commented May 3, 2023

Brief description of the issue

Strange behavior shown by these buttons.

How to reproduce the bug?

Article highlighter button:

  1. Select multiple options one after another then observe the dropdown menu

Article filter button:

  1. Select multiple filters then observe the icon and its tooltip.
  2. Select a filter or filters, then select "No extra filtering". Restart the app and check

What was the expected result?

Normal behavior from both buttons

What actually happened?

Article highlighter button:

A visual bug. Selecting a highlight option doesn't remove the selection from any previously selected option(s) in the dropdown menu unless you restart the app.
ScreenShot_20230503225843

Article filter button:

  1. If you have multiple filters selected, it will only display one icon and description which can get really confusing. IMO there should be a separate unique icon for this case named something like "Multiple filters selected".
    ScreenShot_20230503221453
    ScreenShot_20230503221941

  2. Selecting "No extra filtering" removes all other filter selections (as it should), but upon restart of the app you'll find out that it doesn't do anything and your current filter choices remain unchanged.

Debug log

Operating system and version

  • OS: Win 10 x64
  • RSS Guard version: 4.3.4
@Rex000 Rex000 added the Type-Defect This is BUG!!! label May 3, 2023
@martinrotter
Copy link
Owner

image

Fixed both visually and as a feature.

martinrotter added a commit that referenced this issue Jun 22, 2023
@martinrotter martinrotter added this to the 4.4.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants