Changes for good index (and other markdown) rendering on GitLab and Codeberg #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of 'main' The DEFAULT_BRANCH environment variable can still be used to override it.
This change may need some revisiting, because it copies over code from the build-index.sh.
chrysn
changed the title
chrysn
force-pushed
the
for-forgejo-2
branch
2 times, most recently
from
8fb1cf6
to
9aa0960
Compare
|
I think I've addressed my own concerns by 1. taking the pattern already established in wg-meta.sh (no need for a function call here, the variables are populated at sourcing time), and 2. applying this to get the old "GitHub" text as a hostlabel that is looked up based on the git host. The only remaining differences a
|
|
I think that this is now similarly mature as #399 was: It should not alter the output of GitHub workflows any more. |
martinthomson
approved these changes
Sep 14, 2023
| # default-branch.py recognition only works on GitHub; on other hosters it needs | ||
| # to be set manually (also around setup.mk!), or they just use the default | ||
| # value. | ||
| DEFAULT_BRANCH := main |
There was a problem hiding this comment.
Suggested change
| DEFAULT_BRANCH := main | |
| DEFAULT_BRANCH ?= main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #399
(which to my knowledge I can't indicate to GitHub in a way that it only shows the commits after "Support non-GitHub hosts for .note.xml generation")[edit: A force push of a fixed commit message after 399 was merged did resolve this], these are changes that'd make using Codeberg & co easier,but they'll probably need some rework after discussion.As before with #399, I'd like to leave this sit for some time until I request review (while still having it available for the curious).
Prominent points I'm not too happy with are:
The changed setup-readme.sh more or less copies over (and extends) the big per-host switch that is already in build-index.sh. I suppose having a script like wg-meta.sh would be the place to outsource this?[edit: Now doing something very similar to wg-meta.sh in host-meta.sh]Existing output is changed where GitHub is replaced with github.com. If 1. is properly resolved, there could be a host label that'd be used in its place.[edit: There is now a hostlabel variable generated for known hosters]