tuple-hash-fix #102
Merged
tuple-hash-fix #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinus
force-pushed
the
2023-12-tuple-hash-fix
branch
3 times, most recently
from
9ef728e
to
2ac87c7
Compare
Hashing is now similar to abseil, which is essentially doing the same.
martinus
force-pushed
the
2023-12-tuple-hash-fix
branch
from
2ac87c7
to
1155545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usiing has_unique_object_representations is not allowed, as it is also true for std::string_view. So I've now switched to std::is_integral_type.
Also, changed the implementation to be very similar to what Abseil is doing. Benchmarks have shown that this is much faster.