Command alias doesn't work in repo-level config

[martinvonz]

Description

I'm filing this on @ppwwyyxx's behalf. Copying from #982 (comment):

This is what I got:

❯ 14:18 cd $(mktemp -d) ; jj init --git
Initialized repo in "."
❯ 14:18 echo 'aliases.foo = ["diff"]' > .jj/repo/config.toml
❯ 14:18 jj config list aliases.foo
❯ 14:18 jj config --no-pager list aliases.foo
aliases.foo=["diff"]
❯ 14:18 jj foo
error: unrecognized subcommand 'foo'

Usage: jj [OPTIONS] [COMMAND]

For more information, try '--help'.

Specifications

• Platform: unknown
• Version: 0.10.0-8dbe12da2a6d771d3409b19b76bf0f8781e6b218

[martinvonz]

I have no idea what the problem could be here. @ppwwyyxx, can you think of anything unusual in your setup? What else do you have in your config? Is jj a shell alias? What shell do you use?

[yuja]

There's a TODO about this. The repository path isn't determined until the command arguments gets parsed.

jj/cli/src/cli_util.rs

Lines 2783 to 2802 in 171896a

	let config = layered_configs.merge();
	ui.reset(&config)?;
	let string_args = expand_args(ui, &self.app, std::env::args_os(), &config)?;
	let (matches, args) = parse_args(
	ui,
	&self.app,
	&self.tracing_subscription,
	&string_args,
	&mut layered_configs,
	)?;
	for process_global_args_fn in self.process_global_args_fns {
	process_global_args_fn(ui, &matches)?;
	}
	let maybe_workspace_loader = init_workspace_loader(&cwd, &args.global_args);
	if let Ok(loader) = &maybe_workspace_loader {
	// TODO: maybe show error/warning if repo config contained command alias
	layered_configs.read_repo_config(loader.repo_path())?;
	}
	let config = layered_configs.merge();

Possible workarounds:

• show warning (as the comment says)
• load temporary repo config from cwd and use it only for command alias expansion
• parse command arguments without aliases as much as possible, and use -R to load temporary repo config

In any case, it's better to show warning if the repository path was different from the one we use for alias expansion.