test_revset.rs: disable clippy false-positive warning #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
approved these changes
Jun 11, 2023
I opened a bug for the clippy error: frondeus/test-case#122
I couldn't find an easy way to do that, surprisingly. Apparently, there's a special crate to make it possible. So, I used a slightly less elegant solution. |
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Jul 10, 2023
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances.
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Jul 10, 2023
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation.
|
Good news: AFAICT, frondeus/test-case#122 is fixed now in every Rust version (possibly requiring a |
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Jul 11, 2023
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation. For example, until mitsuhiko/insta#389 is fixed, you can put the following into your `Cranky.toml`: ```toml allow = [ "clippy::needless_raw_string_hashes" ] ``` Then, you can have VS code use `cargo cranky` instead of `cargo check` or `cargo clippy` and continue to use nightly clippy. The other possible solution, of course, would be to switch to beta clippy.
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Jul 11, 2023
https://github.com/ericseppanen/cargo-cranky seems like a useful tool for cases like mitsuhiko/insta#389 (cc martinvonz#1834) and martinvonz#1686. It should probably not be checked in, though. It can be put into `.git/info/excludes`, but that's harder on non-colocated repos and I'm not 100% certain jj properly ignores the files in there in all circumstances. The idea is to use this with VS Code or to simplify command-line clippy invocation. For example, until mitsuhiko/insta#389 is fixed, you can put the following into your `Cranky.toml`: ```toml allow = [ "clippy::needless_raw_string_hashes" ] ``` Then, you can have VS code use `cargo cranky` instead of `cargo check` or `cargo clippy` and continue to use nightly clippy. The other possible solution, of course, would be to switch to beta clippy.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened a bug for the clippy error:
frondeus/test-case#122