Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .gitignore handling of ignored directories #2109

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

qfel
Copy link
Collaborator

@qfel qfel commented Aug 18, 2023

This addresses #2051.

  • Ignore .gitignore files from untracked directories
  • Do not allow un-ignoring files within ignored directories
  • Make it more clear how GitIgnoreFile works

Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that!

lib/src/gitignore.rs Outdated Show resolved Hide resolved
lib/src/gitignore.rs Show resolved Hide resolved
 - Ignore .gitignore files from untracked directories
 - Do not allow un-ignoring files within ignored directories
@qfel qfel enabled auto-merge (rebase) August 23, 2023 04:21
@martinvonz
Copy link
Owner

"Check protos" failed due to some network error, quite clearly unrelated to the PR. I started a re-run of that job.

@qfel qfel merged commit 2109a7b into martinvonz:main Aug 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants