Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: inline CommandHelper::new() #3181

Merged
merged 2 commits into from
Mar 2, 2024
Merged

cli: inline CommandHelper::new() #3181

merged 2 commits into from
Mar 2, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Mar 2, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits March 2, 2024 13:06
@yuja
cli: inline CommandHelper::new()
4717090 
This constructor has too many arguments enough to introduce a parameter struct,
which would be identical to the CommandHelper type. Let's simply inline it as
there are no external callers.
@yuja
cli: canonicalize cwd earlier and rely on that
8b25e96
@yuja yuja merged commit 42f9ced into martinvonz:main Mar 2, 2024
16 checks passed
@yuja yuja deleted the push-uuwtykkvvzxo branch March 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuja @PhilipMetzger