Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note about jj edit to Git comparison #3184

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

bnjmnt4n
Copy link
Collaborator

@bnjmnt4n bnjmnt4n commented Mar 2, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link

google-cla bot commented Mar 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is marked as a draft, but it already looks good to me

@bnjmnt4n bnjmnt4n marked this pull request as ready for review March 2, 2024 19:28
@bnjmnt4n
Copy link
Collaborator Author

bnjmnt4n commented Mar 2, 2024

I've signed the CLA with this email and my GitHub username, clicking the rescan gives me an error 400.

@martinvonz
Copy link
Owner

I've signed the CLA with this email and my GitHub username, clicking the rescan gives me an error 400.

The check passed now anyway. I have sometimes had to go to an internal page to force a re-scan, but that wasn't necessary this time.

I've also invited you as a contributor so you can merge PRs yourself once you have approval.

@bnjmnt4n bnjmnt4n merged commit f135e09 into martinvonz:main Mar 3, 2024
16 checks passed
@bnjmnt4n
Copy link
Collaborator Author

bnjmnt4n commented Mar 3, 2024

I've also invited you as a contributor so you can merge PRs yourself once you have approval.

Thanks! Will being seeing what else I can contribute to!

@bnjmnt4n bnjmnt4n deleted the push-npkyqumz branch March 3, 2024 08:23
@PhilipMetzger
Copy link
Collaborator

FYI, I re-ran the check yesterday so there was no action required :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants