clippy: disable bogus lints for nightly clippy #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly compiler has several clippy fix-its that, if applied, break the build. There are various bugs about this, but there isn't enough space in the margins to detail it all. Just ignore these on a per-function basis; about 70% of them are just multiple instances happening inside a single function. This makes `cargo clippy --workspace --all-targets` run clean, even with the nightly compiler. Signed-off-by: Austin Seipp <aseipp@pobox.com> Change-Id: Ic26a025d3c62b12fbf096171308b56e38f7d1bb9
thoughtpolice
force-pushed
the
aseipp/push-xqrwmzyqwtnx
branch
from
6782544
to
1105366
Compare
|
I'm not sure what's best to do here in general, but now that you wrote this, let's use it! I think the My current solution is to use https://github.com/ericseppanen/cargo-cranky and put # Cranky.toml
allow = [
# "unknown_lints", # Needed on beta channell
"clippy::assigning_clones",
"clippy::manual_unwrap_or_default",
]Another option for Here are some related bugs and a PR. rust-lang/rust-clippy#12610 |
ilyagr
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting with using nightly inside the Nix build, in order to use the parallel rustc frontend and cranelift, and this really helps avoid bogus/spurious clippy warnings.
I suspect @ilyagr might have opinions on this, since he's tracked a bunch of these regressions along with me.
As an alternative to
#[allow(unknown_lints)]— which I am not a huge fan of — I think we could also wire up abuild.rsthat detects the rustc version and emitscargo:rustc-cfg=nightlywhich would allow us to conditionalize the macro on#[cfg(nightly)]. But maybe this is good enough.