Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: file: sort subcommands chronologically #3910

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Jun 18, 2024

Otherwise they wouldn't be sorted in help. I also reordered the match statement. Since subcommands are split to per-file modules, there's no point to keep some logical ordering.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Otherwise they wouldn't be sorted in help. I also reordered the match statement.
Since subcommands are split to per-file modules, there's no point to keep some
logical ordering.
@yuja yuja enabled auto-merge (rebase) June 18, 2024 01:35
Copy link
Collaborator

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Chronologically" means "time-based"; do you mean "alphabetically" or "lexicographically"?

@yuja yuja merged commit 4ab1fc9 into martinvonz:main Jun 18, 2024
17 checks passed
@yuja yuja deleted the push-wkxtplyymwxm branch June 18, 2024 01:45
@arxanas
Copy link
Collaborator

arxanas commented Jun 18, 2024

Oops, maybe it was on auto-merge

@yuja
Copy link
Collaborator Author

yuja commented Jun 18, 2024

"Chronologically" means "time-based"; do you mean "alphabetically" or "lexicographically"?

Right, I meant "lexicographically", sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants