-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake.nix #66
Add flake.nix #66
Conversation
paging @colemickens and @arxanas for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a CI job to verify the Nix build? Example here: https://github.com/arxanas/git-branchless/blob/master/.github/workflows/nix-linux.yml. (git-branchless
would break the Nix build all the time if not for that.)
Thanks!
I guess this is about adding a note to the installation instructions? Makes sense. Anything else I should wait for before merging the PR? Were @arxanas and @colemickens happy with the review? (Sorry if that's indicated somewhere. I'm new to collaborating on GitHub, and especially the mobile UI.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI passes.
flake.nix looks good, I think my only feedback would be to try to patch the version so that this is more accurate:
Ideally that might look like:
or something like that. Not a blocker though! Love to see it, Nix ftw! |
Fixes #61