Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake.nix #66

Merged
merged 7 commits into from
Feb 20, 2022
Merged

Add flake.nix #66

merged 7 commits into from
Feb 20, 2022

Conversation

pingiun
Copy link
Contributor

@pingiun pingiun commented Feb 20, 2022

Fixes #61

  • Tests pass
  • Appropriate changes to README are included in PR

@pingiun
Copy link
Contributor Author

pingiun commented Feb 20, 2022

paging @colemickens and @arxanas for review

flake.nix Outdated Show resolved Hide resolved
flake.lock Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Copy link
Collaborator

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a CI job to verify the Nix build? Example here: https://github.com/arxanas/git-branchless/blob/master/.github/workflows/nix-linux.yml. (git-branchless would break the Nix build all the time if not for that.)

flake.nix Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@martinvonz
Copy link
Owner

Fixes #61

Thanks!

  • Appropriate changes to README are included in PR

I guess this is about adding a note to the installation instructions? Makes sense.

Anything else I should wait for before merging the PR? Were @arxanas and @colemickens happy with the review? (Sorry if that's indicated somewhere. I'm new to collaborating on GitHub, and especially the mobile UI.)

Copy link
Collaborator

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes.

@colemickens
Copy link
Contributor

flake.nix looks good, I think my only feedback would be to try to patch the version so that this is more accurate:

❯ nix run github:martinvonz/jj/9fb580b6eeba2bbd79658f9777000cabb2ebdaed -- --version
jj 0.2.0 

Ideally that might look like:

❯ nix run github:martinvonz/jj/9fb580b6eeba2bbd79658f9777000cabb2ebdaed -- --version
jj unstable-9fb580b6

or something like that. Not a blocker though! Love to see it, Nix ftw!

@martinvonz martinvonz merged commit c3a5ea0 into martinvonz:main Feb 20, 2022
@pingiun pingiun deleted the add-flake branch February 21, 2022 14:50
@pingiun pingiun mentioned this pull request Feb 21, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Nix packages
4 participants