Restructure aspect integration tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martis42
force-pushed
the
restructure_aspect_tests
branch
from
92bff07
to
a49b255
Compare
The new test framework has the same design as used by the automatic fixes test framework: Individual test are dedicated files. This moves the test definitions closer to the code they are testing and also allows custom logic and explanatory comments in the tests. Also we decouple the test cases from the workspace bazelrc file to gain more flexibility in using Bazel flags which are only available for some Bazel versions. Furthermore, we improve efficiency by: - Combining some test cases which had no reason for separation besides the old test framework not supporting target patterns for multiple targets. - using `--nolegacy_external_runfiles`
Normally they are enforced automatically. But one could have created a commit with `--no-verify` which would then not be recognized until the CI runs.
More explanatory name and fix wrong content from error in test framework migration
martis42
force-pushed
the
restructure_aspect_tests
branch
from
a49b255
to
08fe16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test framework has the same design as used by the automatic fixes test framework: Individual test are dedicated files. This moves the test definitions closer to the code they are testing and also allows custom logic and explanatory comments in the tests.
Also we decouple the test cases from the workspace bazelrc file to gain more flexibility in using Bazel flags which are only available for some Bazel versions.
Furthermore, we improve efficiency by:
--nolegacy_external_runfiles