Make aspect tests proper integration tests #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporating bzlmod and creating the examples showed us that we overlooked problems due to the old test setup not being real integration tests. Now DWYU is a proper external dependency for the integration tests, as it is in the examples.
We promise compatibility with Python 3.8 and thus should use it as default. Otherwise we might use modern Python features by accident and not realize it until the integration tests run.
All tests requiring an old Bazel version are located inside the integration tests and examples which have their won sub workspaces. Thus we can drop support for the legacy WORKSPACE setup in the main repo. At the same time we simplify the main toolchain. It requires only a single version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating bzlmod and creating the examples showed us that we overlooked problems due to the old test setup not being real integration tests.
Now DWYU is a proper external dependency for the integration tests, as it is in the examples.