apply_fixes: Improve dependency discovery heuristic #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our old logic fails when multiple dependencies provide a header file with the same name at different paths. The new logic is robust against this due to looking for the full include path. Looking at the file name is now only a fallback used to resolve cases where include path manipulation makes a simple include path match impossible.
martis42
force-pushed
the
improve_apply_fixes_heuristic
branch
from
de03013
to
c4d4d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old logic fails when multiple dependencies provide a header file with the same name at different paths.
The new logic is robust against this due to looking for the full include path. Looking at the file name is now only a fallback used to resolve cases where include path manipulation makes a simple include path match impossible.
Fixes: #237