Use re.match(pattern, include) for ignored include patterns
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martis42 Maybe we should document the code that was used to match against ignored include patterns and provides some more examples. |
storypku
force-pushed
the
jiaming/ignore_pattern
branch
2 times, most recently
from
ce4caae
to
68e5a74
Compare
|
I believe you have a point. Still, I would like to think this through in detail. For today my time budget for DWYU is exhausted. |
storypku
force-pushed
the
jiaming/ignore_pattern
branch
from
68e5a74
to
90622dc
Compare
Done. Please help re-review. |
storypku
commented
Jan 12, 2023
| @@ -2,6 +2,6 @@ | |||
| "ignore_include_patterns": [ | |||
| "foo/.*", | |||
| "bar/.*", | |||
| "./ignored_sub_path/.*" | |||
| "\\w+/ignored_sub_path/.*" | |||
| ] | |||
There was a problem hiding this comment.
Should we add also an acceptance test case here for ingore_include_patterns to mismatch?
martis42
reviewed
Jan 12, 2023
| @@ -2,6 +2,6 @@ | |||
| "ignore_include_patterns": [ | |||
| "foo/.*", | |||
| "bar/.*", | |||
| "./ignored_sub_path/.*" | |||
| "\\w+/ignored_sub_path/.*" | |||
| ] | |||
If instead we use `re.search(pattern, include)`, include `baz/a/b.h` will be matched against pattern 'a/.*', which should be an unexpected behavior.
storypku
force-pushed
the
jiaming/ignore_pattern
branch
from
90622dc
to
774f483
Compare
martis42
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If instead we use
re.search(pattern, include), includebaz/a/b.hwill be matched against patterna/.*, which should be an unexpected behavior.